Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make datagen work without CARGO_PKG_RUST_VERSION environment variable #4292

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Make datagen work without CARGO_PKG_RUST_VERSION environment variable #4292

merged 3 commits into from
Nov 15, 2023

Conversation

robertbastian
Copy link
Member

This is for better compatibility with other build systems.

@sffc sffc removed their request for review November 14, 2023 20:07
@robertbastian robertbastian changed the title Make datagen work with CARGO_PKG_RUST_VERSION environment variable Make datagen work without CARGO_PKG_RUST_VERSION environment variable Nov 14, 2023
@robertbastian robertbastian requested a review from a team as a code owner November 14, 2023 20:18
Manishearth
Manishearth approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, i considered doing this as a followup but wasn't planning on getting around to it soon

@robertbastian robertbastian merged commit 6e93719 into unicode-org:main Nov 15, 2023
28 checks passed
@robertbastian robertbastian deleted the msrv branch December 7, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertbastian @Manishearth